Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/Fin/Basic): split off rev lemmas #20833

Closed
wants to merge 7 commits into from

Conversation

BoltonBailey
Copy link
Collaborator

This PR splits out lemmas about the Fin.rev function from Data.Fin.Basic. This addresses an instance of a long file linter trigger.


Open in Gitpod

@BoltonBailey BoltonBailey added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jan 18, 2025
Copy link

github-actions bot commented Jan 18, 2025

PR summary b0b660667c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
There are 3919 files with changed transitive imports taking up over 170246 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.02)
Current number Change Type
58 -1 large files

Current commit b0b660667c
Reference commit 3c8e6314aa

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jan 18, 2025
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 21, 2025

✌️ BoltonBailey can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@BoltonBailey
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 22, 2025
This PR splits out lemmas about the `Fin.rev` function from `Data.Fin.Basic`. This addresses an instance of a long file linter trigger.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Fin/Basic): split off rev lemmas [Merged by Bors] - chore(Data/Fin/Basic): split off rev lemmas Jan 22, 2025
@mathlib-bors mathlib-bors bot closed this Jan 22, 2025
@mathlib-bors mathlib-bors bot deleted the BoltonBailey/split-fin-rev branch January 22, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge t-data Data (lists, quotients, numbers, etc) tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants