-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(CategoryTheory): Functor.prod and Functor.prod' are final #20841
Conversation
TwoFX
commented
Jan 19, 2025
•
edited
Loading
edited
PR summary ef4ceb5caf
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.CategoryTheory.Filtered.Final | 580 | 581 | +1 (+0.17%) |
Import changes for all files
Files | Import difference |
---|---|
13 filesMathlib.CategoryTheory.Comma.Final Mathlib.CategoryTheory.Filtered.Final Mathlib.CategoryTheory.Limits.FinallySmall Mathlib.CategoryTheory.Limits.Indization.Category Mathlib.CategoryTheory.Limits.Indization.Equalizers Mathlib.CategoryTheory.Limits.Indization.FilteredColimits Mathlib.CategoryTheory.Limits.Indization.IndObject Mathlib.CategoryTheory.Limits.Indization.LocallySmall Mathlib.CategoryTheory.Limits.Indization.Products Mathlib.Condensed.Discrete.Characterization Mathlib.Condensed.Discrete.Colimit Mathlib.Topology.Category.LightProfinite.Extend Mathlib.Topology.Category.Profinite.Extend |
1 |
Declarations diff
+ IsFiltered.isSifted
+ IsFilteredOrEmpty.isSiftedOrEmpty
+ instance [F.Final] [G.Final] : (F.prod G).Final
+ instance [F.Final] [G.Final] : (F.prod' G).Final
+ instance [IsCofilteredOrEmpty C] (X : C × C) : IsCofiltered (CostructuredArrow (diag C) X) := by
+ instance [IsFilteredOrEmpty C] (X : C × C) : IsFiltered (StructuredArrow X (diag C)) := by
- instance [IsCofiltered C] (X : C × C) : IsCofiltered (CostructuredArrow (diag C) X) := by
- instance [IsFiltered C] (X : C × C) : IsFiltered (StructuredArrow X (diag C)) := by
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
8449d35
to
62bfdcc
Compare
Thanks! bors merge |
Co-authored-by: Markus Himmel <[email protected]>
Pull request successfully merged into master. Build succeeded: |