Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(CategoryTheory): Functor.prod and Functor.prod' are final #20841

Closed
wants to merge 4 commits into from

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Jan 19, 2025


Open in Gitpod

Copy link

github-actions bot commented Jan 19, 2025

PR summary ef4ceb5caf

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Filtered.Final 580 581 +1 (+0.17%)
Import changes for all files
Files Import difference
13 files Mathlib.CategoryTheory.Comma.Final Mathlib.CategoryTheory.Filtered.Final Mathlib.CategoryTheory.Limits.FinallySmall Mathlib.CategoryTheory.Limits.Indization.Category Mathlib.CategoryTheory.Limits.Indization.Equalizers Mathlib.CategoryTheory.Limits.Indization.FilteredColimits Mathlib.CategoryTheory.Limits.Indization.IndObject Mathlib.CategoryTheory.Limits.Indization.LocallySmall Mathlib.CategoryTheory.Limits.Indization.Products Mathlib.Condensed.Discrete.Characterization Mathlib.Condensed.Discrete.Colimit Mathlib.Topology.Category.LightProfinite.Extend Mathlib.Topology.Category.Profinite.Extend
1

Declarations diff

+ IsFiltered.isSifted
+ IsFilteredOrEmpty.isSiftedOrEmpty
+ instance [F.Final] [G.Final] : (F.prod G).Final
+ instance [F.Final] [G.Final] : (F.prod' G).Final
+ instance [IsCofilteredOrEmpty C] (X : C × C) : IsCofiltered (CostructuredArrow (diag C) X) := by
+ instance [IsFilteredOrEmpty C] (X : C × C) : IsFiltered (StructuredArrow X (diag C)) := by
- instance [IsCofiltered C] (X : C × C) : IsCofiltered (CostructuredArrow (diag C) X) := by
- instance [IsFiltered C] (X : C × C) : IsFiltered (StructuredArrow X (diag C)) := by

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-category-theory Category theory label Jan 19, 2025
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 19, 2025
@TwoFX TwoFX added the WIP Work in progress label Jan 19, 2025
@TwoFX TwoFX removed WIP Work in progress awaiting-author A reviewer has asked the author a question or requested changes labels Jan 21, 2025
@TwoFX TwoFX changed the title feat: Functor.prod' is final feat: Functor.prod and Functor.prod' are final Jan 21, 2025
@joelriou joelriou changed the title feat: Functor.prod and Functor.prod' are final feat(CategoryTheory): Functor.prod and Functor.prod' are final Jan 21, 2025
@joelriou
Copy link
Collaborator

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 21, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 21, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): Functor.prod and Functor.prod' are final [Merged by Bors] - feat(CategoryTheory): Functor.prod and Functor.prod' are final Jan 21, 2025
@mathlib-bors mathlib-bors bot closed this Jan 21, 2025
@mathlib-bors mathlib-bors bot deleted the final-prod-prime branch January 21, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants