-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: The Ahlswede-Zhang identity #8171
Conversation
The Ahlswede-Zhang identity is a sharpening of the [Lubell-Yamamoto-Meshalkin inequality](https://leanprover-community.github.io/mathlib_docs/combinatorics/set_family/lym.html#finset.sum_card_slice_div_choose_le_one), by expliciting the correction term. This PR defines `Finset.truncatedSup`/`Finset.truncatedInf`, whose cardinalities show up in the correction term, and subsequently proves the Ahlswede-Zhang identity itself.
/-- The infimum of the elements of `s` less than `a` if there are some, otherwise `⊥`. -/ | ||
def truncatedInf (s : Finset α) (a : α) : α := | ||
if h : a ∈ upperClosure s then (s.filter (· ≤ a)).inf' (inf_aux h) id else ⊥ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you add ⊥
? The natural choice would seem to be top
, since that's the inf of an empty set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why it's called "truncated". The theorem is not true otherwise.
Note this was already PRed to mathlib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, so is this a forward-port PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intent is not to actually forward-port it, we should just revert it in mathlib3 to get it off the dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to make this a forward-port. But note that the second half of the file is not a forward-port
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, it doesn't show up on the dashboard right now. So I'd be in favor of waiting for this PR to be merged before adding the aligns.
Co-authored-by: Eric Wieser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Johan Commelin <[email protected]>
Co-authored-by: Johan Commelin <[email protected]>
bors merge |
The Ahlswede-Zhang identity is a sharpening of the [Lubell-Yamamoto-Meshalkin inequality](https://leanprover-community.github.io/mathlib_docs/combinatorics/set_family/lym.html#finset.sum_card_slice_div_choose_le_one), by expliciting the correction term. This PR defines `Finset.truncatedSup`/`Finset.truncatedInf`, whose cardinalities show up in the correction term, and subsequently proves the Ahlswede-Zhang identity itself. Co-authored-by: Vladimir Ivanov <[email protected]>
Build failed (retrying...): |
Please merge |
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Canceled. |
bors merge |
The Ahlswede-Zhang identity is a sharpening of the [Lubell-Yamamoto-Meshalkin inequality](https://leanprover-community.github.io/mathlib_docs/combinatorics/set_family/lym.html#finset.sum_card_slice_div_choose_le_one), by expliciting the correction term. This PR defines `Finset.truncatedSup`/`Finset.truncatedInf`, whose cardinalities show up in the correction term, and subsequently proves the Ahlswede-Zhang identity itself. Co-authored-by: Vladimir Ivanov <[email protected]>
Pull request successfully merged into master. Build succeeded: |
The Ahlswede-Zhang identity is a sharpening of the Lubell-Yamamoto-Meshalkin inequality, by expliciting the correction term.
This PR defines
Finset.truncatedSup
/Finset.truncatedInf
, whose cardinalities show up in the correction term, and subsequently proves the Ahlswede-Zhang identity itself.Co-authored-by: Vladimir Ivanov [email protected]
This is a rehash of leanprover-community/mathlib3#18612 and leanprover-community/mathlib3#18618.