-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are the example incomplete or are even the vision examples actually rather toy-like? Or is it just cifarfs? #302
Comments
also it seems some of the interfaces assume train, val and test set have the same transforms? |
after further inspection mini-imagenet seems to have the literature standard transforms:
but perhaps cifarfs is the only one that does not? |
I guess what I am looking for is the official way to pass my own transforms to the data sets from l2l |
Hi @brando90, Indeed, we've implemented some of the most common transforms used in the literature. Regarding your last question: the point is to exactly replicate common benchmarks from the literature, so we're explicitly not allowing people to pass their own transforms. I recommend implementing your own benchmarks (like you already did in your other issue). |
to avoid cross posting to much. It seems to me the cirfar-fs transforms are missing something but your mini-imagenet are not.
… On Feb 7, 2022, at 6:49 PM, Séb Arnold ***@***.***> wrote:
Hi @brando90 <https://github.com/brando90>,
Indeed, we've implemented some of the most common transforms used in the literature.
Regarding your last question: the point is to exactly replicate common benchmarks from the literature, so we're explicitly not allowing people to pass their own transforms. I recommend implementing your own benchmarks (like you already did in your other issue).
—
Reply to this email directly, view it on GitHub <#302 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOE6LUZG4OEO7KZMHOEMUDU2BSBNANCNFSM5NUC2DRA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.
|
@seba-1511 I still think this is wrong. Cifarfs needs to have data transfroms. The standard one (from rfs) is the following:
|
probably needs to debugging but here is an attempt for the whole code:
I think you can find a working version in my ultimate-utils library. |
@seba-1511 why doesn't cifar have data augmentation implemented? |
Hi Seba,
Apologies if it seems like a complaint -- it's not. But just wanted to clarify. I was going through the examples and they seemed to lack the standard data transforms that ppl use when running real experiments for a paper. e.g.
from
https://github.com/WangYueFt/rfs/blob/f8c837ba93c62dd0ac68a2f4019c619aa86b8421/dataset/cifar.py#L26
is this correct? Is the standard data transforms that people usually do are not portrayed in the examples. There are no "serious" examples right?
Thanks for your library! Really loving to be able to run an experiment in 1 day rather than 15...+ I like how it's nicely organized. Kudos!
The text was updated successfully, but these errors were encountered: