-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenBVE perhaps return to Debian again...!? #330
Comments
Interesting! I agree debian/copyright is missing, will add that back again. I've got no real experience with Debian packaging, and the current package is based upon a combination of the original scripts and some tweaking of my own. She was relatively happy to chat, but nothing happened, and I think she had a lot of other stuff on her plate too. |
fetch from the http://snapshot.debian.org/package/openbve/1.4.0.10-3/, some more deficiency files. He said that he will be a sponsor if you prepares and emails the necessary documents and the appropriate deb file. |
The last active package maintainer in Debian was actually @sladen, I just had some oversight as part of my general control of .NET in Debian |
This repository is the upstream these days. The release branch and the point releases should provide the snapshots you're after I think. The history should be contiguous from the last source Michelle released although I'd have to check that; the packaging and other build scripts have been later additions on the top, as well as a lot of (ongoing) reorganisation. Essentially, I think what this needs is a clear list of points Debian would like us to address? |
OK, so I've had a quick look back into the commits and the linked repo from @sladen The commit tree for this repo starts here: I appear to have started from a base of Michelle's last released ZIP source (1.4.3.0), and done some work before importing this into the GIT repo. Sladen has a set of repositories which are split by program, so that each of the tools lives in it's own repository. Thoughts / TODO List:
|
@leezer3, it's 10 years ago, so things may be a little hazy.
For the content side, we had three examples (all thanks to Anthony):
The route/train/cab/plugins are not OpenBVE-specific per-se, they are in BVE-CSV fileformat and could also be used with eg. the original BVE Trainsim non-free freeware program + tools. Hence the It would be great to bring the tools into the main repository, and I'm sure Debian/Ubuntu would be very happy to follow whatever Upstream does! |
No trouble. I've been in this community since 1997 or there abouts, and have seen the entire gamut of BVE..... Main Program:I've actually done some playing with cross-architecture proxying for i386 plugins: This works acceptably(ish), but it's not code I was ever happy with. Data:The data included in the current releases has grown somewhat since the original days. At present, it's this:
At 5mb compressed, whether a separate package is worth the trouble is something Debian would have to decide. Tools:My instinct would be to include with the main program, and use executable names prefixed with openBVE as follows:
An alternative would be to add a Developer Tools button / dialog to the main menu, which would avoid adding anything to the path? Content:I'm happy to provide 3 more fully cross-platform locos & assorted consists ( GWR 81xx, GWR Manor, BR Class 52 ) in public domain / BSD-3 if we feel that is a good idea. None of these work correctly on the original BVE trainsim however. (n.b. openBVE introduced both the 3D cab and train exteriors, so neither of these work per-se with the original BVE Trainsim) Route-wise is somewhat more complex, and I don't think there's anything easily available that could be added. As opposed to Michelle's original managed content system. a relatively early implementation was a basic package manager. This isn't anything particularly special, just reads a metadata XML from a zip, and allows installation / removal etc. Other:The issue of the licence mess Michelle left us with pops up every once in a while: We have agreement from all the non-trivial contributors to this repository that a move to BSD is acceptable in principle, and TBQH the current licence probably would allow us to do this anyways. |
OK, have done rather a lot of messing around with the generated deb. This is now clean of all red lintian warnings, other than the lack of a changelog. However, there are still some flaws:
This really needs someone familiar with Debian packaging to take a look now though. |
Okay, so, taking a look at the packaging metadata, I feel it would be much easier to maintain in the longer term by using some newer conventions - right now it's using format version 5 from 2005 (https://github.com/sladen/openbve/blob/debian/debian/compat) and 75% of that file would go away with version 7 from 2008. https://salsa.debian.org/dotnet-team/xsddiagram/blob/master/debian/rules is an example of a Debhelper 7 rules file for a project built entirely from sln/csproj - and half of that file is a custom rule for downloading the .tar.gz. Some of the automagic things in dh7 would likely help you |
Sorry, I should have given a bit more context as to what's happening.
Means "for every Debian packaging rule, just do whatever the Then for every command
|
Thanks! The current in-tree script we've got (and which I've been modifiying today) actually builds the solution (Uses mcs , not xbuild) before copying it into the Debian package structure and calling dpkg-deb to build the thing. After today's work, it declares format V7, which if I understand correctly isn't actually doing much in this case, as I'm essentially just packing binary files. If I understand what's going on with the rules file correctly, the only real advantage would be that we could just call the dpkg creation command in the root directory, and dpkg would sort everything else out? |
For a "use Debian packaging on a tarball of binaries not source" your example is https://github.com/mono/linux-packaging-nuget But bear in mind this strategy isn't ok for inclusion in packaging repositories |
OK, so I've got some progress, but I'll admit this is giving me a real headache. Due to a lot of changes to the structure of things (specifically intended to reduce the amount of duplicate code between the main program and the viewers), the build order is rather important. Attempting to do this manually is a PITA and requires manual work every time something changes. As it looks likely that the tools may be included with the main program, I think this makes the easiest method of doing things to be to simply build the main solution file directly, and let this handle the build order itself. I think we'll need a separate target, or a call to delete the data, but keep that back until the deb is actually generating..... Current state of play This is the current test commit.
|
Can you stick the full build log in gist? Some is missing Also, it looks like you included some temporary files in your commit - you can delete all files with substvars or debhelper in the filename |
https://gist.github.com/leezer3/bf8a4e5fd3ab1485cb35b209cb6d3650 Full build log. I'm sure there are plenty of other flaws in my build logic, so please don't spend too much time on this. Happy enough to keep fiddling myself once I understand it a little better :) |
dllmap issues - the installed assemblies dllimport native libs whose packages can't be determined - e.g. You can either exclude the named things by adding You also have one shlibs issue for |
Thanks. I've got it building now, although I had to disable EGL, KVM and some other stuff from checking. TODO:
|
Test generated deb & the two other generated files. |
・Who should be packaging / signing? ・Related, we need to figure out who the maintainer actually is. We have an offer from henrich, @sladen is still I think the current maintainer, or what? |
To create deb package more easily, may be helps this tool? |
For the record, the
|
Mr.leeser3, if you are ready to deb package, please send the email to [email protected] with WNPP template, and report me. |
I'm still working on it in the linked branch :) We now have basic wrappers for the Object Viewer / Route Viewer binaries, but for some reason the menu entry isn't triggering correctly. When I'm done, the linked branch will get merged into mainline, and hopefully added to the CI. |
I heard that this marge is ready to come back to debian from @s520 . |
It seems to build the deb OK on Stretch, but not on Jessie. |
s520: there is no contradict;
|
@sladen |
From Debian's perspective, the debian/copyright file is: https://salsa.debian.org/debian/openbve/blob/debian/sid/debian/copyright Most of which appears to still be as-written 10 years ago; and hopefully the Debian FTP master team would review the information in the same form. The |
henrichは全てのファイルにライセンスとauthors/copyright holdersを書くように言いました。 しかし、問題があります。 |
Where is the text "The OpenBVE Project"? In: says:
and: says:
|
下記のような記述を考えていました。 |
At the moment, there is no legal entity/company/foundation called "The OpenBVE Project". On could do something like OpenStreetMap which requires:
as short-hand (abbreviation) + URL link to: which contains lots of information about who the contributors are ("Our contributors are thousands of individuals."). As a first-step, a page like eg: needs creating, which everyone's names on. If that is not possible, it is better to add the exact names to each individual file; showing which files each copyright holder created/modified/edited. (The full Git history may be useful here). At the moment there is zero copyright iformatin |
分かりました。 |
@sladen |
At the bottom of: the webpage currently says: © 2019 The OpenBVE Project. Powered by Jekyll. ideally this should be corrected, for example:
Or something like this. The important part is the placing into the Public Domain/BSD-2-line licence. |
Nobody should feel the need to promise anything. People (humans, everyone) do their best—sometimes it takes time. An important reason for open/Public Domain/Free Software/sharing is that there is no requirement to ask, or re-ask earlier authors. The contributions are, given, forever. It was ~10 years since OpenBVE was first uploaded to Ubuntu/Debian. It would be wonderful to get OpenBVE back into Debian/Ubuntu, along with even more routes (@leezer3 offered to release some GWR cabs under a proper licence). Please do not worry! We'll get there; it just takes time. |
First a note: I'm at work & won't really have a chance to properly respond to this discussion until tomorrow at the earliest. Contributor Lists:We have a basic list of major contributors in here, but no specifics: https://github.com/leezer3/OpenBVE/blob/master/Contributing.md We could also do with a CLA adding. This has been alluded to in the file above, and all contributors have been asked, but formalise it. Website:This can be tweaked, should just be in the Jekyll template. Legal Entity:This is a funny one. My instinct is that under UK Law, 'the openBVE Project' would be just fine as a trading name assuming the backend group (us!) exists. It really depends what Debian et. al want though- We're only custodians of the name through maintaining the active fork. |
@leezer3 |
@leezer3 |
It doesn't matter :) What I think is important though is that we all take a step back and think. A hasty solution is almost never the right one. BVE was around well before OpenBVE was ever concieved of, and I'm sure a while longer won't hurt. |
I agree. |
I agree with your opinion. |
On Mon, 30 Sep 2019 09:42:43 -0700 s520 ***@***.***> wrote:
なお、なぜ疑問を呈したのかhenrichは理由を述べませんでした。
Your attitude is so harmful for me, you said "You said a question,
so you SHOULD give more detail about it, you're a blocker for our
work".
**sigh**
It was my fault that I've misread leezer3's post at BTS and did not take
any action for months (apologizes), however, I just wanted to do some
help to OpenBVE (at that time).
s520, are you some kind of paid customer, or my boss? (or my wife? ;)
Should I send a bill?
…--
Regards,
Hideki Yamane henrich @ debian.org/iijmio-mail.jp
|
I just wanted a constructive discussion. |
@leezer3 |
On Tue, 01 Oct 2019 08:03:44 -0700 s520 ***@***.***> wrote:
I just wanted a constructive discussion.
Then please **behave** so. Please.
I just gave you some question, then you would not say your
idea/thought about it, and just claim me to explain the reason
the reason why I asked, aggressively.
Well, is it a constructive discussion? NO, clearly not (at least for me).
And, you _did_ the same thing, again.
Of course I don't want to squeeze what I said, but you didn't apologize on Twitter.
So why now say “apologizes”?
And I said that “I apologize for making you feel uncomfortable”. This is my clear apology.
You don't understand what was wrong, just _saying_ "clear apology"...
If you get the idea, you wouldn't say so. Why should I explain it
as a defendant in a court? (You treat me as it, I'm not sure you're
aware of it or not).
To be clear, I don't have any duty to put openbve package to Debian
(I'm sorry), just wanted to do some help at that time (yes, at that
time). However, it seems that you misunderstand it. Unfortunately,
you seem that do not understand people have a different idea, priority,
and motivation.
If you forcefully order to do something to someone, you should pay
something, or behave to be more polite as someone wants to do so.
…--
Hideki Yamane <[email protected]>
|
For constructive discussions ;),
* debian/copyright should be clear one, better to be machine-readable
copyright format 1.0. There's no reason to be old style.
* Removing debian directory from master branch is better, it causes
conflicts with distro packaging. If you stay it, making a branch
for it (maybe ubuntu or something?)
* Using CI thing in salsa is good, put debian/salsa-ci.yml
I've enabled it in repo.
* Anyway, please pull master from github and try to merge it
to debian/sid branch, if debian/ directory moves away from
master.
|
I've done some work on this today. Whilst I'm only loosely following the written Japanese conversation & social nuances (Mostly via translator- I can acceptably follow spoken Japanese TV etc. but not written) it's clear that we all need to step back and think before we write anything. This also seems an opportune point to again remind all parties involved that nobody is getting paid here, least of all me! |
A Japanese user, that is Five Motor Sound's creator says that 'You can register to the Snap Store, is it? |
Interesting thought. Flatpaks, Snaps et. al are definitely gaining a little in functionality/ support, but they're also a mess internally, and would involve a far larger download size (although we wouldn't be hosting it) as they need to package the complete Mono runtime and associated stuff. |
How to interact with debian |
Relative with #261.
Today, via Twitter, a Debian Developer henrich is conversation to me.
https://twitter.com/henrich
He say that if you mails to Debian's WNPP, he becomes to the sponser.
Please send WNPP to [email protected].
If recoverly to debian, you(Mr.leeser3) can continue to registration to debian directly.
At https://www.clear-code.com/blog/2014/3/7.html, the WNPP's prototype mail foramat is written.
Additionally, he checked your OpenBVE's .deb, and he advice to me.
He say that some files are still not ready for registration.
For example, debian/copyright.
The deficiency files should to attach based from bellow.
http://snapshot.debian.org/package/openbve/1.4.0.10-3/
Additionally, perhaps you are not use official deb packaging tool.
If you use official deb creating tool, it is so smart.
I will continue to contact to developper henrich.
If you sent to email to [email protected], please announce to me.
I tweet to him.
The text was updated successfully, but these errors were encountered: