Skip to content

refactor: introduce type resource.ID #2467

refactor: introduce type resource.ID

refactor: introduce type resource.ID #2467

Triggered via pull request November 5, 2024 21:54
@leg100leg100
synchronize #704
refactor-id
Status Failure
Total duration 1m 25s
Artifacts

build.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
build: internal/api/client_test.go#L20
cannot use "ws-1" (untyped string constant) as resource.ID value in struct literal
build: internal/api/client_test.go#L21
cannot use "ws-2" (untyped string constant) as resource.ID value in struct literal (compile)
build: internal/module/api.go#L123
invalid operation: "/modules/download/" + version.ID (mismatched types untyped string and "github.com/leg100/otf/internal/resource".ID)
build: internal/module/db.go#L97
cannot use vcsProviderID (variable of type string) as "github.com/leg100/otf/internal/resource".ID value in argument to sql.ID
build: internal/module/db.go#L168
cannot use row.ModuleID.String (variable of type string) as "github.com/leg100/otf/internal/resource".ID value in struct literal
build: internal/module/db.go#L178
cannot use row.VCSProviderID.String (variable of type string) as "github.com/leg100/otf/internal/resource".ID value in struct literal
build: internal/module/db.go#L188
cannot use row.ModuleVersions[i].ModuleVersionID.String (variable of type string) as "github.com/leg100/otf/internal/resource".ID value in struct literal
build: internal/module/db.go#L192
cannot use row.ModuleVersions[i].ModuleID.String (variable of type string) as "github.com/leg100/otf/internal/resource".ID value in struct literal
build: internal/module/module.go#L126
cannot use m.ID (variable of type "github.com/leg100/otf/internal/resource".ID) as string value in argument to slog.String
build: internal/module/module.go#L169
cannot use v.ID (variable of type "github.com/leg100/otf/internal/resource".ID) as string value in argument to slog.String
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build
No files were found with the provided path: internal/integration/screenshots/**/*.png. No artifacts will be uploaded.