Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For observability purposes we need to have a way to reference a specific version of the config. For example for tracking rollouts or to see what value was used during debugging.
We already have
sha
field which is git-style sha of the content, but it's hard to lookup the config content using it (unless we build some additional tooling).We also report
commit_sha
in many places, but it's global for the repo, so it will change if there are new commits even if those commits didn't modify the specific config that we are looking at.Change
I propose to use sha of the last commit that modified the config as it's version. We already know it on rollout, we just need to store it and pass it around. The only issue is with local git mode as we'd need to use
git log
to get sha of the last update for every config. I think it should be fine, but worst case we can just not report it with local git setup.