Add optional params when there is a presence check #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -405,6 +415,12 @@ func translateRuleTS(rule *rulesv1beta3.Rule, usedVariables map[string]string) s | |||
| case rulesv1beta3.ComparisonOperator_COMPARISON_OPERATOR_ENDS_WITH: | |||
| usedVariables[v.Atom.ContextKey] = structpbValueToKindString(v.Atom.ComparisonValue) | |||
| return fmt.Sprintf("(%s.endsWith(%s))", v.Atom.ContextKey, try.To1(marshalOptions.Marshal(v.Atom.ComparisonValue))) | |||
| case rulesv1beta3.ComparisonOperator_COMPARISON_OPERATOR_PRESENT: | |||
There was a problem hiding this comment.
Is this sufficient?
Like what if I have:
if a.contains("foo")
return false
if a !== undefined
return true
There was a problem hiding this comment.
So you are saying we should always move the undefined check first? Or that logic above should not be allowed?
There was a problem hiding this comment.
I'm saying that in that particular situation, "a" should not be optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds presence ts code gen
Makes params optional if there is a check for presence. Will use "string | boolean | number" type if there are no comparison values or grab the type from the usedVariables if it ever was compared to a value.
If there are any presence checks, we'll use optional value safe methods on strings