Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurate collection to capped and update documentation #9

Merged
merged 8 commits into from
Mar 19, 2017
Merged

Configurate collection to capped and update documentation #9

merged 8 commits into from
Mar 19, 2017

Conversation

FedeG
Copy link
Member

@FedeG FedeG commented Mar 9, 2017 •
edited
Loading

Fix #8

@FedeG FedeG requested a review from andreareginato March 9, 2017 20:15
@FedeG FedeG mentioned this pull request Mar 9, 2017
Open
andreareginato
andreareginato requested changes Mar 12, 2017
View reviewed changes
Copy link
Contributor

@andreareginato andreareginato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is the need to improve the documentation. There are different parts that still point out to heroku (which needs to be removed) and to localhost:3002 that needs to be updated with the current dev URIs you set up with Docker.

@andreareginato andreareginato merged commit 03e60db into lelylan:master Mar 19, 2017
@andreareginato
Copy link
Contributor

The localhost:3002 is defined in the README @FedeG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreareginato andreareginato andreareginato requested changes

Assignees

@andreareginato andreareginato

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FedeG @andreareginato