Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webpack.*.ts importing values from src/ #4992

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Remove webpack.*.ts importing values from src/ #4992

merged 3 commits into from
Apr 13, 2022

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Mar 10, 2022

  • Remove global modifying __static

Signed-off-by: Sebastian Malton [email protected]

@Nokel81 Nokel81 added the chore label Mar 10, 2022
@Nokel81 Nokel81 added this to the 5.5.0 milestone Mar 10, 2022
@Nokel81 Nokel81 requested a review from jakolehm March 10, 2022 22:41
@Nokel81 Nokel81 requested a review from a team as a code owner March 10, 2022 22:41
@Nokel81 Nokel81 requested review from nevalla and removed request for a team March 10, 2022 22:41
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@aleksfront aleksfront requested a review from ixrock March 16, 2022 10:29
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

ixrock
ixrock previously approved these changes Mar 29, 2022
View reviewed changes
tsconfig.json
Comment on lines +35 to +39
"plugins": [
{
"name": "typescript-plugin-css-modules"
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably could be removed (css-modules supported by webpack's css-loader)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is here to support intellisense for css modules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it doesn't. For VScode you still have to install some plugin.
Recommended extension: https://marketplace.visualstudio.com/items?itemName=phoenisx.cssvar

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://www.npmjs.com/package/typescript-plugin-css-modules#visual-studio-code it seems that this is enough.

webpack/extensions.ts Show resolved Hide resolved
webpack/main.ts Show resolved Hide resolved
webpack/renderer.ts Outdated Show resolved Hide resolved
webpack/tsconfig.json Show resolved Hide resolved
webpack/vars.ts Outdated Show resolved Hide resolved
@Nokel81 Nokel81 requested a review from ixrock March 29, 2022 14:01
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Nokel81 Nokel81 requested a review from ixrock April 1, 2022 20:26
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Conflicts have been resolved. A maintainer will review the pull request shortly.

jim-docker
jim-docker reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just coincidence? Lens won't start (make clean && make dev) for this branch but does start on master. Gets stuck here:
Screen Shot 2022-04-04 at 7 37 19 PM

Tried thrice with this branch (no start), thrice with master (all start)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Iku-turso
Iku-turso requested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@Iku-turso Iku-turso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/lensapp/lens/pull/4992/files#r849236015

@Nokel81
Remove webpack.*.ts importing values from src/
c2d1c57 
- Remove global modifying __static

Signed-off-by: Sebastian Malton <[email protected]>
@Nokel81
move webpackDevServerPort to webpack/vars
d355a8d 
Signed-off-by: Sebastian Malton <[email protected]>
@Nokel81
fix react-refresh-webpack=plugin use
8e1a740 
Signed-off-by: Sebastian Malton <[email protected]>
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Nokel81 Nokel81 merged commit e977890 into master Apr 13, 2022
@Nokel81 Nokel81 deleted the remove-webpack-imports branch April 13, 2022 14:39
@Nokel81 Nokel81 mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-docker jim-docker jim-docker approved these changes

@ixrock ixrock ixrock approved these changes

@Iku-turso Iku-turso Iku-turso approved these changes

@jakolehm jakolehm Awaiting requested review from jakolehm

@nevalla nevalla Awaiting requested review from nevalla nevalla is a code owner automatically assigned from lensapp/lens-ide

@jansav jansav Awaiting requested review from jansav

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Nokel81 @Iku-turso @ixrock @jim-docker