Fix findClosestVersionTagLessThanVersion in release tool #7374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <[email protected]>
Nokel81
requested review from
ixrock and
gabriel-mirantis
and removed request for
a team
aleksfront
approved these changes
Mar 17, 2023
ixrock
reviewed
Mar 17, 2023
| @@ -120,7 +120,7 @@ function findClosestVersionTagLessThanVersion(tags: string[], version: SemVer): | |||
| .filter(isDefined) | |||
| .filter(version => !version.prerelease.includes("cron")) | |||
| .sort(semver.rcompare) | |||
| .filter(version => semver.lte(version, version)); | |||
| .filter(v => semver.lte(v, version)); | |||
There was a problem hiding this comment.
What's changed here except renamed variable for filtering?
There was a problem hiding this comment.
There were two variables in this function called "version" that was the bug
Nokel81
added a commit
that referenced
this pull request
Mar 20, 2023
Signed-off-by: Sebastian Malton <[email protected]>
gabriel-mirantis
pushed a commit
that referenced
this pull request
Mar 21, 2023
Signed-off-by: Sebastian Malton <[email protected]> Signed-off-by: Gabriel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.