Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-compaction][leo_storage] Compaction is not executed when some nodes are empty #455

Closed
windkit opened this issue Mar 3, 2016 · 2 comments

Comments

@windkit
Copy link
Contributor

windkit commented Mar 3, 2016

Description

Put an object to LeoFS and then delete it, one would expect auto compaction will start and reclaim the disk space, but it won't happen

Cause

  1. When some storage nodes are empty, Zero division error happens in checking candidates for compaction
  2. Errors are caught at leo_storage_sub but do not leave any error logs
@yosukehara yosukehara added this to the 1.2.20 milestone Mar 3, 2016
@yosukehara yosukehara self-assigned this Mar 3, 2016
yosukehara added a commit to leo-project/leo_storage that referenced this issue Mar 3, 2016
yosukehara added a commit to leo-project/leo_watchdog that referenced this issue Mar 3, 2016
yosukehara added a commit to leo-project/leo_storage that referenced this issue Mar 3, 2016
@yosukehara
Copy link
Member

@windkit I've fixed this issue. When you have time, please test it.

@windkit
Copy link
Contributor Author

windkit commented Mar 3, 2016

@yosukehara I can confirm this issue is fixed with the commits.

@windkit windkit closed this as completed Mar 3, 2016
@yosukehara yosukehara changed the title [leo_storage] Compaction is not executed when some nodes are empty [data-compaction][leo_storage] Compaction is not executed when some nodes are empty Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants