Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-eslint in / from 8.2.1 to 10.0.1 #225

Closed
wants to merge 1 commit into from

Conversation

dependencies[bot]
Copy link

@dependencies dependencies bot commented Oct 1, 2018

Dependencies.io has updated babel-eslint (a npm dependency in /) from "8.2.1" to "10.0.1".

10.0.1

The TypeAlias "conversion" to a function has issues. Sounds like we need to rethink the change, most likely we can just actually change the scoping rather than hardcode an AST change.

10.0.0

Small breaking change: add a peerDependency starting from the ESLint version that added a parser feature that we were monkeypatching before (and drop that code). If already using ESLint 5 shouldn't be any different.

/* flow */
type Node<T> = { head: T; tail: Node<T> }

// or 

type File = {chunks: Array<Chunk>}
type Chunk = {file: File}
9.0.0

We've released v7: https://twitter.com/left_pad/status/1034204330352500736, so this just updates babel-eslint to use those versions internally. That in itself doesn't break anything but:

  • Babel now supports the new decorators proposal by default, so we need to switch between the new and the old proposal. This is a breaking change.

To enable the legacy decorators proposal users should add a specific parser option:

{
  parserOptions: {
    ecmaFeatures: {
      legacyDecorators: true
    }
  }
}
  • Babel removed the support for Node 4 , so I propagated that here.

@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           3        3           
  Lines          12       12           
  Branches        2        2           
=======================================
  Hits           11       11           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf9acd...cb4df60. Read the comment docs.

@leonardofaria
Copy link
Owner

Deploy preview for leozera-ui ready!

Built with commit cb4df60

https://deploy-preview-225--leozera-ui.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants