New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow locale to use a `fs.FS` #68

Merged

leonelquinteros merged 2 commits into leonelquinteros:master from kobergj:AddFSToLocale

Mar 17, 2023

Contributor

kobergj commented Mar 16, 2023

Is this a fix, improvement or something else?

We are using an embed.FS to embed translations while building our binaries, so we do not need to ship the translations alongside the binary. Unfortunately the locale object relies on os methods to read the files.

This PR allows adding an optional fs.FS from which files will be read if it is not nil. When not adding a fs the functionality and implementation stays the same.
...

What does this change implement/fix?

Added additional NewLocaleFS, NewPoFS and NewMoFS functions to create the object with a fs.
Added a switch to read from the fs when it is defined (in findExt and getFileData)
...

I have ...

answered the 2 questions above,
discussed this change in an issue,
included tests to cover this changes.


          allow locale to work with a fs.FS

9d5a301

Signed-off-by: jkoberg <[email protected]>

Owner

leonelquinteros commented Mar 16, 2023

Hi, thank you for your contribution.
Could you add tests for your use cases to cover this changes?


          test fs alongside os implementation

8ebc12b

Signed-off-by: jkoberg <[email protected]>

Contributor Author

kobergj commented Mar 17, 2023

Of course I can. Sorry you needed to ask 😉

I reused existing tests to make sure all functionality is covered. Also during test implementation I recognized path parameter is unneeded in the fs case. I removed it to avoid confusion.

leonelquinteros merged commit 71a59c0 into leonelquinteros:master

nono referenced this pull request in cozy/cozy-stack


          fix(deps): update module github.com/leonelquinteros/gotext to v1.6.0 (#…

3f4c8ed

…4376)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/leonelquinteros/gotext](https://togithub.com/leonelquinteros/gotext)
| `v1.5.2` -> `v1.6.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fleonelquinteros%2fgotext/v1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fleonelquinteros%2fgotext/v1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fleonelquinteros%2fgotext/v1.5.2/v1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fleonelquinteros%2fgotext/v1.5.2/v1.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>leonelquinteros/gotext
(github.com/leonelquinteros/gotext)</summary>

###
[`v1.6.0`](https://togithub.com/leonelquinteros/gotext/releases/tag/v1.6.0)

[Compare
Source](https://togithub.com/leonelquinteros/gotext/compare/v1.5.2...v1.6.0)

#### What's Changed

- Allow locale to use a `fs.FS` by
[@&#8203;kobergj](https://togithub.com/kobergj) in
[https://github.com/leonelquinteros/gotext/pull/68](https://togithub.com/leonelquinteros/gotext/pull/68)
- Runtime translation detection by
[@&#8203;m-horky](https://togithub.com/m-horky) in
[https://github.com/leonelquinteros/gotext/pull/69](https://togithub.com/leonelquinteros/gotext/pull/69)
- feat: Add language getter for Locale by
[@&#8203;taozhou-glean](https://togithub.com/taozhou-glean) in
[https://github.com/leonelquinteros/gotext/pull/77](https://togithub.com/leonelquinteros/gotext/pull/77)
- Allow setting global storage by
[@&#8203;didrocks](https://togithub.com/didrocks) in
[https://github.com/leonelquinteros/gotext/pull/80](https://togithub.com/leonelquinteros/gotext/pull/80)
- Fix multiline export by
[@&#8203;didrocks](https://togithub.com/didrocks) in
[https://github.com/leonelquinteros/gotext/pull/82](https://togithub.com/leonelquinteros/gotext/pull/82)
- Order locations in ascii order by
[@&#8203;didrocks](https://togithub.com/didrocks) in
[https://github.com/leonelquinteros/gotext/pull/83](https://togithub.com/leonelquinteros/gotext/pull/83)
- Fix io/fs File leak by
[@&#8203;diamondburned](https://togithub.com/diamondburned) in
[https://github.com/leonelquinteros/gotext/pull/79](https://togithub.com/leonelquinteros/gotext/pull/79)
- Add support for multiple languages by
[@&#8203;m-horky](https://togithub.com/m-horky) in
[https://github.com/leonelquinteros/gotext/pull/73](https://togithub.com/leonelquinteros/gotext/pull/73)
- Revert "Add support for multiple languages" by
[@&#8203;leonelquinteros](https://togithub.com/leonelquinteros) in
[https://github.com/leonelquinteros/gotext/pull/84](https://togithub.com/leonelquinteros/gotext/pull/84)
- Remove unused dependency by
[@&#8203;der-lyse](https://togithub.com/der-lyse) in
[https://github.com/leonelquinteros/gotext/pull/86](https://togithub.com/leonelquinteros/gotext/pull/86)
- Fix typo in documentation by
[@&#8203;der-lyse](https://togithub.com/der-lyse) in
[https://github.com/leonelquinteros/gotext/pull/87](https://togithub.com/leonelquinteros/gotext/pull/87)
- Add support for multiple languages by
[@&#8203;m-horky](https://togithub.com/m-horky) in
[https://github.com/leonelquinteros/gotext/pull/85](https://togithub.com/leonelquinteros/gotext/pull/85)

#### New Contributors

- [@&#8203;kobergj](https://togithub.com/kobergj) made their first
contribution in
[https://github.com/leonelquinteros/gotext/pull/68](https://togithub.com/leonelquinteros/gotext/pull/68)
- [@&#8203;m-horky](https://togithub.com/m-horky) made their first
contribution in
[https://github.com/leonelquinteros/gotext/pull/69](https://togithub.com/leonelquinteros/gotext/pull/69)
- [@&#8203;taozhou-glean](https://togithub.com/taozhou-glean) made their
first contribution in
[https://github.com/leonelquinteros/gotext/pull/77](https://togithub.com/leonelquinteros/gotext/pull/77)
- [@&#8203;didrocks](https://togithub.com/didrocks) made their first
contribution in
[https://github.com/leonelquinteros/gotext/pull/80](https://togithub.com/leonelquinteros/gotext/pull/80)
- [@&#8203;diamondburned](https://togithub.com/diamondburned) made their
first contribution in
[https://github.com/leonelquinteros/gotext/pull/79](https://togithub.com/leonelquinteros/gotext/pull/79)
- [@&#8203;der-lyse](https://togithub.com/der-lyse) made their first
contribution in
[https://github.com/leonelquinteros/gotext/pull/86](https://togithub.com/leonelquinteros/gotext/pull/86)

**Full Changelog**:
leonelquinteros/gotext@v1.5.2...v1.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cozy/cozy-stack).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

llonchj mentioned this pull request

go embed fs with path #98

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet