Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decimal steps & margin: 'margin' must be divisible by step error #1163

Closed
leongersen opened this issue Oct 9, 2021 · 3 comments
Closed

decimal steps & margin: 'margin' must be divisible by step error #1163

leongersen opened this issue Oct 9, 2021 · 3 comments
Labels
Bug Confirmed bugs

Comments

@leongersen
Copy link
Owner

Still doesn't work for a some combinations of the value and step:

(1221.64 / 0.01) % 1
= 1.4551915228366852e-11

(1221.62 / 0.01) % 1
0.9999999999854481

Step/value combination is required for the currency amount

Originally posted by @Alex-Popov in #736 (comment)

@leongersen leongersen added the Bug Confirmed bugs label Oct 9, 2021
@leongersen
Copy link
Owner Author

@Alex-Popov I've just released noUiSlider 15.5.0, which removes this constraint. noUiSlider now handles mismatches in step and margin/padding/limit well, so this constraint is no longer needed. Thanks for reporting your edge-case!

@Alex-Popov
Copy link

@leongersen Thanks a lot!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Confirmed bugs
Projects
None yet
Development

No branches or pull requests

2 participants