-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nvidia/remapped-rows): do not check row remapping for 4090 and other unsupported GPUs #351
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 22.55% 22.92% +0.37%
==========================================
Files 289 289
Lines 25869 25883 +14
==========================================
+ Hits 5835 5934 +99
+ Misses 19433 19340 -93
- Partials 601 609 +8 ☔ View full report in Codecov by Sentry. |
436c61f
to
af902d8
Compare
07eb968
to
a67ace7
Compare
2e40b7a
to
0c3f9b5
Compare
components/accelerator/nvidia/remapped-rows/component_output.go
Outdated
Show resolved
Hide resolved
f192dd1
to
34bff02
Compare
…her unsupported GPUs Fix > nvidia-smi GPU GPU 00000000:E1:00.0 failed to determine if it qualifies for RMA: invalid remapping failure occurred value: "", GPU product name "NVIDIA GeForce RTX 4090" does not support row remapping (message: "GPU product name: \"NVIDIA GeForce RTX 4090\" Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
34bff02
to
f7f807c
Compare
…PUProduct Signed-off-by: Gyuho Lee <[email protected]>
f7f807c
to
d8d3aa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fix