Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nvidia/remapped-rows): do not check row remapping for 4090 and other unsupported GPUs #351

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Feb 3, 2025

Fix

nvidia-smi GPU GPU 00000000:E1:00.0 failed to determine if it qualifies for RMA: invalid remapping failure occurred value: "", GPU product name "NVIDIA GeForce RTX 4090" does not support row remapping (message: "GPU product name: "NVIDIA GeForce RTX 4090"

@gyuho gyuho added this to the v0.4.0 milestone Feb 3, 2025
@gyuho gyuho self-assigned this Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 65.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 22.92%. Comparing base (19e2296) to head (d8d3aa6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
components/accelerator/nvidia/query/query.go 0.00% 12 Missing ⚠️
...celerator/nvidia/remapped-rows/component_output.go 81.08% 5 Missing and 2 partials ⚠️
...nts/accelerator/nvidia/query/nvml/remapped_rows.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   22.55%   22.92%   +0.37%     
==========================================
  Files         289      289              
  Lines       25869    25883      +14     
==========================================
+ Hits         5835     5934      +99     
+ Misses      19433    19340      -93     
- Partials      601      609       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyuho gyuho force-pushed the row-remapping-fix-for-nvidia-smi branch from 436c61f to af902d8 Compare February 3, 2025 15:43
@gyuho gyuho force-pushed the row-remapping-fix-for-nvidia-smi branch from 07eb968 to a67ace7 Compare February 4, 2025 05:55
@gyuho gyuho added wip - do not merge working in progress and removed wip - do not merge working in progress labels Feb 4, 2025
@gyuho gyuho force-pushed the row-remapping-fix-for-nvidia-smi branch from 2e40b7a to 0c3f9b5 Compare February 4, 2025 08:49
@gyuho gyuho force-pushed the row-remapping-fix-for-nvidia-smi branch 2 times, most recently from f192dd1 to 34bff02 Compare February 6, 2025 09:33
gyuho added 2 commits February 6, 2025 22:35
…her unsupported GPUs

Fix

> nvidia-smi GPU GPU 00000000:E1:00.0 failed to determine if it qualifies for RMA: invalid remapping failure occurred value: "", GPU product name "NVIDIA GeForce RTX 4090" does not support row remapping (message: "GPU product name: \"NVIDIA GeForce RTX 4090\"

Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho force-pushed the row-remapping-fix-for-nvidia-smi branch from 34bff02 to f7f807c Compare February 6, 2025 14:39
@gyuho gyuho force-pushed the row-remapping-fix-for-nvidia-smi branch from f7f807c to d8d3aa6 Compare February 6, 2025 14:40
Copy link
Collaborator

@cardyok cardyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho merged commit dfe1658 into main Feb 6, 2025
6 checks passed
@gyuho gyuho deleted the row-remapping-fix-for-nvidia-smi branch February 6, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants