test: refactor: Limit the target of nowarn annotation

- Easy to understand - Unrelated warnings are not ignored
lerna-stack · Jul 15, 2021 · f563b43 · f563b43
1 parent 4ceaaa8
commit f563b43
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 22 deletions.
diff --git a/src/multi-jvm/scala/lerna/akka/entityreplication/ConsistencyTestBase.scala b/src/multi-jvm/scala/lerna/akka/entityreplication/ConsistencyTestBase.scala
@@ -73,7 +73,7 @@ object ConsistencyTestBase {
     }
   }
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class ConsistencyTestReplicationActor() extends ReplicationActor[Int] {
 
     import ConsistencyTestReplicationActor._

diff --git a/src/multi-jvm/scala/lerna/akka/entityreplication/ConsistencyTestNormal.scala b/src/multi-jvm/scala/lerna/akka/entityreplication/ConsistencyTestNormal.scala
@@ -15,7 +15,7 @@ class ConsistencyTestNormalMultiJvmNode3 extends ConsistencyTestNormal
 class ConsistencyTestNormalMultiJvmNode4 extends ConsistencyTestNormal
 class ConsistencyTestNormalMultiJvmNode5 extends ConsistencyTestNormal
 
-@nowarn // for deprecated ClusterReplication(system).start
+@nowarn("msg=method start in class ClusterReplication is deprecated")
 class ConsistencyTestNormal extends MultiNodeSpec(ConsistencyTestBaseConfig) with STMultiNodeSpec with Inside {
 
   import ConsistencyTestBaseConfig._

diff --git a/src/multi-jvm/scala/lerna/akka/entityreplication/RaftActorCompactionSpec.scala b/src/multi-jvm/scala/lerna/akka/entityreplication/RaftActorCompactionSpec.scala
@@ -24,9 +24,9 @@ object RaftActorCompactionSpecConfig extends MultiNodeConfig {
       .withFallback(ConfigFactory.parseString("""
       akka.actor.provider = cluster
       akka.test.single-expect-default = 15s
-      
+
       lerna.akka.entityreplication.raft.multi-raft-roles = ["replica-group-1", "replica-group-2", "replica-group-3"]
-      
+
       // triggers compaction each event replications
       lerna.akka.entityreplication.raft.compaction.log-size-threshold = 2
       lerna.akka.entityreplication.raft.compaction.preserve-log-size = 1
@@ -80,7 +80,7 @@ object RaftActorCompactionSpec {
 
   import DummyReplicationActor._
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class DummyReplicationActor extends ReplicationActor[State] {
 
     private[this] var state: State = State(0)
@@ -209,7 +209,7 @@ class RaftActorCompactionSpec extends MultiNodeSpec(RaftActorCompactionSpecConfi
     }
   }
 
-  @nowarn // for deprecated ClusterReplication(system).start
+  @nowarn("msg=method start in class ClusterReplication is deprecated")
   def createReplication(typeName: String): ActorRef =
     planAutoKill {
       ClusterReplication(system).start(

diff --git a/src/multi-jvm/scala/lerna/akka/entityreplication/RaftEventSourcedSpec.scala b/src/multi-jvm/scala/lerna/akka/entityreplication/RaftEventSourcedSpec.scala
@@ -25,7 +25,7 @@ object RaftEventSourcedSpecConfig extends MultiNodeConfig {
       akka.test.single-expect-default = 15s
       lerna.akka.entityreplication.raft.multi-raft-roles = ["member-1", "member-2", "member-3"]
       lerna.akka.entityreplication.recovery-entity-timeout = 1s
-      
+
       inmemory-journal {
         event-adapters {
           dummy-event-adapter = "lerna.akka.entityreplication.RaftEventSourcedSpec$DummyEventAdapter"
@@ -92,7 +92,7 @@ object RaftEventSourcedSpec {
 
   import DummyReplicationActor._
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class DummyReplicationActor extends ReplicationActor[State] {
 
     private[this] var state: State = State(count = 0, knownRequestId = Set.empty)
@@ -152,7 +152,7 @@ object RaftEventSourcedSpec {
   }
 }
 
-@nowarn // for deprecated ClusterReplication(system).start
+@nowarn("msg=method start in class ClusterReplication is deprecated")
 class RaftEventSourcedSpec extends MultiNodeSpec(RaftEventSourcedSpecConfig) with STMultiNodeSpec {
 
   import RaftEventSourcedSpec._

diff --git a/src/multi-jvm/scala/lerna/akka/entityreplication/ReplicationActorMultiNodeSpec.scala b/src/multi-jvm/scala/lerna/akka/entityreplication/ReplicationActorMultiNodeSpec.scala
@@ -71,7 +71,7 @@ object ReplicationActorMultiNodeSpec {
     }
   }
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class PingPongReplicationActor extends ReplicationActor[Int] {
 
     import PingPongReplicationActor._
@@ -125,7 +125,7 @@ object ReplicationActorMultiNodeSpec {
     }
   }
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class LockReplicationActor extends ReplicationActor[NotUsed] {
     import LockReplicationActor._
 
@@ -185,7 +185,7 @@ object ReplicationActorMultiNodeSpec {
     }
   }
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class EphemeralReplicationActor extends ReplicationActor[Int] {
 
     import EphemeralReplicationActor._
@@ -223,7 +223,7 @@ class ReplicationActorMultiNodeSpecMultiJvmNode1 extends ReplicationActorMultiNo
 class ReplicationActorMultiNodeSpecMultiJvmNode2 extends ReplicationActorMultiNodeSpec
 class ReplicationActorMultiNodeSpecMultiJvmNode3 extends ReplicationActorMultiNodeSpec
 
-@nowarn // for deprecated ClusterReplication(system).start
+@nowarn("msg=method start in class ClusterReplication is deprecated")
 class ReplicationActorMultiNodeSpec extends MultiNodeSpec(ReplicationActorSpecConfig) with STMultiNodeSpec {
   import ReplicationActorMultiNodeSpec._
   import ReplicationActorSpecConfig._

diff --git a/src/multi-jvm/scala/lerna/akka/entityreplication/ReplicationRegionSpec.scala b/src/multi-jvm/scala/lerna/akka/entityreplication/ReplicationRegionSpec.scala
@@ -48,7 +48,7 @@ object ReplicationRegionSpec {
     }
   }
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class DummyReplicationActor(probe: TestProbe) extends DiagnosticActorLogging with ReplicationActor[Int] {
 
     import DummyReplicationActor._
@@ -116,7 +116,7 @@ object ReplicationRegionSpecConfig extends MultiNodeConfig {
       .withFallback(ConfigFactory.parseString(s"""
       akka.actor.provider = cluster
       akka.test.single-expect-default = 15s
-      
+
       lerna.akka.entityreplication.raft.compaction.log-size-threshold = 2
       lerna.akka.entityreplication.raft.compaction.preserve-log-size = 1
       lerna.akka.entityreplication.raft.compaction.log-size-check-interval = 0.1s
@@ -178,7 +178,7 @@ class ReplicationRegionSpec extends MultiNodeSpec(ReplicationRegionSpecConfig) w
 
     val raftActorProbe = TestProbe("RaftActor")
 
-    @nowarn // for deprecated ClusterReplication(system).start
+    @nowarn("msg=method start in class ClusterReplication is deprecated")
     def createReplication(typeName: String): ActorRef =
       planAutoKill {
         ClusterReplication(system).start(

diff --git a/src/test/scala/lerna/akka/entityreplication/ReplicationActorSpec.scala b/src/test/scala/lerna/akka/entityreplication/ReplicationActorSpec.scala
@@ -31,7 +31,7 @@ object ReplicationActorSpec {
     case class Counted() extends Event
   }
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class ExampleReplicationActor extends ReplicationActor[Int] {
     import ExampleReplicationActor._
 

diff --git a/src/test/scala/lerna/akka/entityreplication/testkit/TestReplicationActorPropsSpec.scala b/src/test/scala/lerna/akka/entityreplication/testkit/TestReplicationActorPropsSpec.scala
@@ -24,7 +24,7 @@ object TestReplicationActorPropsSpec {
     final case class Counted(wordCount: Int) extends DomainEvent
   }
 
-  @nowarn // for deprecated ReplicationActor
+  @nowarn("msg=Use typed.ReplicatedEntityBehavior instead")
   class WordCountReplicationActor extends ReplicationActor[Int] {
     import WordCountReplicationActor._
 
@@ -57,28 +57,26 @@ object TestReplicationActorPropsSpec {
   }
 }
 
+@nowarn("msg=Use typed.testkit.ReplicatedEntityBehaviorTestKit instead")
 class TestReplicationActorPropsSpec extends TestKit(ActorSystem()) with WordSpecLike with Matchers with ImplicitSender {
   import WordCountReplicationActor._
 
   "TestReplicationActorProps" should {
 
     "take in only ReplicationActor Props" in {
-      @nowarn // for deprecated TestReplicationActorProps
       val ex = intercept[IllegalArgumentException] {
         TestReplicationActorProps(Props.default)
       }
       ex.getMessage should be(s"The Props for [${Props.default.actorClass()}] doesn't provide ReplicationActor")
     }
 
     "forward commands to ReplicationActor" in {
-      @nowarn // for deprecated TestReplicationActorProps
       val actor = system.actorOf(TestReplicationActorProps(WordCountReplicationActor.props))
       actor ! CountWord("hello")
       expectMsg(Counted(wordCount = "hello".length))
     }
 
     "allow that ReplicationActor process ensureConsistency" in {
-      @nowarn // for deprecated TestReplicationActorProps
       val actor = system.actorOf(TestReplicationActorProps(WordCountReplicationActor.props))
       actor ! CountWord("hello")
       expectMsgType[Counted]
@@ -87,7 +85,6 @@ class TestReplicationActorPropsSpec extends TestKit(ActorSystem()) with WordSpec
     }
 
     "allow to check ReplicationActor passivation" in {
-      @nowarn // for deprecated TestReplicationActorProps
       val actor = watch(system.actorOf(TestReplicationActorProps(WordCountReplicationActor.props)))
       actor ! Stop() // Passivate