Raft leader should set appropriate previous values (prevLogIndex and prevLogTerm) to batched AppendEntries
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirc
changed the title
prevLogTerm) to batched AppendEntriesprevLogIndex and prevLogTerm) to batched AppendEntries
xirc
force-pushed
the
fix-batched-append-entries
branch
from
d053e60 to
3f86d20
Compare
added 3 commits
January 18, 2022 17:41
…d `prevLogTerm`) to batched AppendEntries The `prevLogIndex` should be the last index of the previous batch. The `prevLogTerm` should be the last term of the previous batch.
xirc
force-pushed
the
fix-batched-append-entries
branch
from
3f86d20 to
17c2370
Compare
xirc
commented
Jan 20, 2022
src/test/scala/lerna/akka/entityreplication/raft/model/ReplicatedLogSpec.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123