Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance leader's replication response handling #160

Merged
merged 9 commits into from
Jul 27, 2022
Merged

Enhance leader's replication response handling #160

merged 9 commits into from
Jul 27, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Jul 12, 2022

  • ReplicationFailed extends ReplicationResponse
  • ReplicationResponse extends EntityCommand
    • ReplicationSucceeded extends EntityCommand via ReplicationResponse
    • ReplicationFaield extends EntityCommand via ReplicationResponse
  • Enhance Leader.receiveReplicationResponse method
    • This method logs a warning when the leader receives the unexpected ReplicaitonFailed
    • Add diagnostic information to a warning message about the unexpected ReplicationSucceeded
  • Add tests for Leader.receiveReplicationResponse

@xirc xirc marked this pull request as ready for review July 13, 2022 00:30
@xirc xirc requested a review from negokaz July 13, 2022 00:30
negokaz
negokaz approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@negokaz negokaz enabled auto-merge July 27, 2022 09:18
@negokaz negokaz merged commit 757daa9 into master Jul 27, 2022
@negokaz negokaz deleted the enhance-leaders-replication-response-handling branch July 27, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xirc @negokaz