Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify replication failure to conflict clients #162

Merged
merged 6 commits into from
Jul 26, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Jul 14, 2022

Closes #155, #156

If conflict clients exist, RaftActor sends ReplicationFaield messages to these clients and removes clients from LeaderData.clients. A client is considered a conflict if an index associated with the client (LeaderData.clients) is conflict one.

@xirc xirc marked this pull request as ready for review July 14, 2022 09:41
@xirc xirc requested a review from negokaz July 14, 2022 09:41
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@negokaz negokaz merged commit e415a69 into master Jul 26, 2022
@negokaz negokaz deleted the notify-replication-failure-to-conflict-clients branch July 26, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An entity could stick at WaitForReplication when a Raft log entry is truncated by conflict
2 participants