Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic logging to CommitLogStoreActor #164

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Add diagnostic logging to CommitLogStoreActor #164

merged 4 commits into from
Jul 29, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Jul 14, 2022

Add the following diagnostic logging to CommitLogStoreActor:

  • [INFO] recovery completed
    • Use INFO level since it is not frequently logged and is useful for log diving.
  • [DEBUG] AppendCommittedEntries with empty entries
    • Use DEBUG level since it is frequently logged.
  • [INFO] saving snapshot
    • Use INFO level since it is not frequently logged and is useful for log diving.

@xirc xirc marked this pull request as ready for review July 14, 2022 10:16
@xirc xirc requested a review from negokaz July 14, 2022 10:16
negokaz
negokaz approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@negokaz negokaz enabled auto-merge July 29, 2022 05:44
@negokaz negokaz merged commit fcc83f3 into master Jul 29, 2022
@negokaz negokaz deleted the diagnostic-logging-commit-log-store branch July 29, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xirc @negokaz