Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unnecessary snapshot synchronization #168

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Aug 3, 2022

Closes #167

RaftActor skips snapshot synchronization if it already has snapshots (or log entries) that the received InstallSnapshot will install. It logs an error if the received InstallSnapshot is inconsistent with its state.

Taichi Yamakawa added 2 commits August 3, 2022 15:47
RaftActor skips snapshot synchronization if it already has snapshots
 (or log entries) that the received InstallSnapshot will install. It
logs an error if the received InstallSnapshot is inconsistent with
its state.
@xirc xirc marked this pull request as ready for review August 4, 2022 02:25
@xirc xirc requested a review from negokaz August 4, 2022 02:25
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 👍

@negokaz negokaz merged commit 10c8ee7 into master Aug 4, 2022
@negokaz negokaz deleted the skip-unnecessary-snapshot-synchronization branch August 4, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot synchronization could remove committed log entries that not be included in snapshots
2 participants