Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function extract shard id from entity id #172

Merged
merged 12 commits into from
Oct 5, 2022
Merged

Add function extract shard id from entity id #172

merged 12 commits into from
Oct 5, 2022

Conversation

ydash
Copy link
Contributor

@ydash ydash commented Oct 3, 2022

Add function extract shard id from entity id.

The function will use checking whether the raft actor is stop or not.

@nyamada-tis
feat: Add ClusterReplication::shardIdOf for extract shardId from enti…
d8f7fcf 
…tyId
@nyamada-tis
test: add test of ClusterReplication::shardIdOf
e2cfc99
@nyamada-tis
refactor: change process of ClusterReplication.shardIdOf with using R…
0ef4415 
…eplicatedEntityTypeKey
@nyamada-tis
docs: add api document of ClusterReplication.shardIdOf
9469d8a
@nyamada-tis
refactor: replace the type Pair(ClusterReplicationSettings, ActorRef[…
5df0267 
…Nothing]) with the type ReplicationRegionEntry
@nyamada-tis
refactor: the type of settings argument of shardIdOf untyped.ClusterR…
93a64be 
…eplicationSettings replace with typed.ClusterReplicationSettings
@nyamada-tis
refactor: replace ActorRef[E] the return type of internalInit with Re…
c818364 
…plicationRegionEntry
@nyamada-tis
refactor: narrow the scope of ClusterReplicationImpl.shardIdOf
cbb2317
@nyamada-tis
test: insert behavior function of ClusterReplication.shardIdOf in Clu…
4d32955 
…sterReplicationSpec
@nyamada-tis
refactor: remove final modifier from ClusterReplicationImpl.Replicati…
3a6aedd 
…onRegionEntry
@nyamada-tis
chore: update mima filter
4172e86
@nyamada-tis
docs: update CHANGELOG.md
61951df
@ydash ydash marked this pull request as ready for review October 4, 2022 01:53
@xirc xirc added this to the v2.2.0 milestone Oct 5, 2022
xirc
xirc approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@xirc xirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@xirc xirc merged commit 618a211 into master Oct 5, 2022
@xirc xirc deleted the 252-impl-shard-id-extractor branch October 5, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirc xirc xirc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ydash @xirc @nyamada-tis