Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling specific raft actor's launching by its own shard id #173

Merged
merged 18 commits into from
Oct 20, 2022
Merged

Disabling specific raft actor's launching by its own shard id #173

merged 18 commits into from
Oct 20, 2022

Conversation

ydash
Copy link
Contributor

@ydash ydash commented Oct 5, 2022 •
edited
Loading

Add feature of disabling raft actor's launching by specifying its own shard id.

Ignore following launching trigger of RaftActor

  • ReplicationRegionRaftActorStarter
  • ReplicationRegion
  • RaftActor

@nyamada-tis
feat: add configuration of disabled shard ids list
c323580
@nyamada-tis
feat: exclude disabled shard ids from given ids when raft actor's sta…
e0ab8d8 
…rts are triggered by ReplicationRegionRaftActorStarter
@nyamada-tis
test: add test of disabling specific shard ids launching when raft ac…
9bf36da 
…tor's starts are triggered by ReplicationRegionRaftActorStarter
@nyamada-tis
refactor: change the type of RaftSettings.disabledShards from List to…
79a562c 
… Set
@nyamada-tis
feat: drop all messages sent to disabled shards in ReplicationRegion.…
ad70cc7 
…deliverMessage
@nyamada-tis
test: add test of dropping all messages sent to disabled shards
1c6bd7a
@nyamada-tis
feat: RaftActor stop itself when its shard id is defined as disabled
ba515b4
@nyamada-tis
test: RaftActor stop itself when its shard id is defined as disabled
9227ea8
@nyamada-tis
feat: RaftActor skip recovery when its shard id is disabled
c79751e
@nyamada-tis
doc: update CHANGELOG.md
48d1428
@ydash ydash marked this pull request as ready for review October 12, 2022 07:32
@ydash ydash changed the title WIP: Disabling specific raft actor's launching by its own shard id Disabling specific raft actor's launching by its own shard id Oct 12, 2022
@xirc xirc self-requested a review October 12, 2022 08:03
xirc
xirc suggested changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@xirc xirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I left some comments.

As same as RaftActor, CommitLogStoreActor also should stop itself if its shard ID is disabled. Would it be possible also to change CommitLogStoreActor? CommitLogStoreActor can use its shardId method to get its shard ID.

src/main/resources/reference.conf Outdated Show resolved Hide resolved
src/main/scala/lerna/akka/entityreplication/ReplicationRegion.scala Outdated Show resolved Hide resolved
src/main/scala/lerna/akka/entityreplication/ReplicationRegion.scala Outdated Show resolved Hide resolved
src/main/resources/reference.conf Outdated Show resolved Hide resolved
src/multi-jvm/scala/lerna/akka/entityreplication/ReplicationRegionSpec.scala Outdated Show resolved Hide resolved
src/test/scala/lerna/akka/entityreplication/raft/RaftActorSpec.scala Show resolved Hide resolved
src/main/scala/lerna/akka/entityreplication/raft/RaftSettings.scala Outdated Show resolved Hide resolved
@ydash
Copy link
Contributor Author

ydash commented Oct 19, 2022

@xirc

As same as RaftActor, CommitLogStoreActor also should stop itself if its shard ID is disabled. Would it be possible also to change CommitLogStoreActor? CommitLogStoreActor can use its shardId method to get its shard ID.

I implemented feature of stopping itself to CommitLogStoreActor.

5f8f982
44e7a8a

xirc
xirc approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@xirc xirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@xirc xirc merged commit c78b5c7 into master Oct 20, 2022
@xirc xirc deleted the feature/stopping-raft-actors-by-its-own-shard-id branch October 20, 2022 06:17
@xirc xirc added this to the v2.2.0 milestone Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz left review comments

@xirc xirc xirc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ydash @negokaz @xirc @nyamada-tis