Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity diagnostic logs #176

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Add entity diagnostic logs #176

merged 6 commits into from
Nov 9, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Oct 18, 2022

Add entity (typed) diagnostic logs:

  • Containing the current entity state (Inactive, Ready, Recovering, WaitForReplication)
  • Logging as TRACE level

@xirc xirc marked this pull request as ready for review October 20, 2022 06:28
@xirc xirc requested a review from negokaz October 20, 2022 06:28
@xirc xirc added this to the v2.2.0 milestone Oct 20, 2022
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xirc

Great! I left a comment.

@xirc xirc force-pushed the add-entity-diagnostic-logs branch from a06019b to 9e1d2a0 Compare November 8, 2022 06:26
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@negokaz negokaz merged commit ff990ea into master Nov 9, 2022
@negokaz negokaz deleted the add-entity-diagnostic-logs branch November 9, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants