Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot synchronization diagnostic logs #177

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Oct 19, 2022

Add snapshot synchronization diagnostic logs:

  • RaftActor logs its snapshot synchronization (started, completed, and failed)
    • While SnapshotSyncManager logs such information, new logs are also helpful in diagnosing interactions between SnapshotSyncManager and RaftActor.
  • SnapshotSyncManager logs:
    • its recovery
    • saving the progress as a snapshot (both success and failure)
    • dropping SyncSnapshot, SaveSnapshotSuccess, and SaveSnapshotFailure
    • progress of snapshot synchronization

@xirc xirc force-pushed the add-snapshot-synchronization-diagnostic-logs branch from e22a2f3 to 9a23d9e Compare October 19, 2022 05:27
@xirc xirc marked this pull request as ready for review October 20, 2022 06:29
@xirc xirc requested a review from negokaz October 20, 2022 06:30
@xirc xirc added this to the v2.2.0 milestone Oct 20, 2022
negokaz
negokaz previously approved these changes Nov 4, 2022
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@negokaz negokaz merged commit 0f22a3e into master Nov 9, 2022
@negokaz negokaz deleted the add-snapshot-synchronization-diagnostic-logs branch November 9, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants