Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ReplicationRegionRaftActorStarter's logger name to its FQCN #178

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Set ReplicationRegionRaftActorStarter's logger name to its FQCN #178

merged 3 commits into from
Nov 7, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Oct 21, 2022

ReplicationRegionRaftActorStarter uses akka.actor.ActorCell as a logger name. While it also includes MDC value akkaSource (https://doc.akka.io/docs/akka/current/typed/logging.html#mdc-values), using FQCN as a logger name helps to diagnose logs. This change sets FQCN of ReplicationRegionRaftActorStarter to the logger name.

@xirc xirc added this to the v2.2.0 milestone Oct 21, 2022
@xirc xirc marked this pull request as ready for review October 21, 2022 03:00
negokaz
negokaz approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@negokaz negokaz enabled auto-merge November 4, 2022 05:14
@negokaz negokaz merged commit 361b0ca into master Nov 7, 2022
@negokaz negokaz deleted the set-replication-region-raft-actor-starter-logger-name branch November 7, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xirc @negokaz