Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic info to logs of sending replication results #179

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Add diagnostic info to logs of sending replication results #179

merged 3 commits into from
Nov 7, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Oct 21, 2022

RaftActor includes the following info to logs of sending replication results:

  • LogEntryIndex of a committed log entry
  • Term of a committed log entry
  • NormalizedEntitytId of a committed log entry
  • The class name of a committed event

@xirc xirc marked this pull request as ready for review October 24, 2022 01:00
@xirc xirc added this to the v2.2.0 milestone Oct 24, 2022
@xirc xirc requested a review from negokaz October 24, 2022 01:00
negokaz
negokaz approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@negokaz negokaz merged commit 7629647 into master Nov 7, 2022
@negokaz negokaz deleted the revise-logs-of-sending-replication-results branch November 7, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xirc @negokaz