Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnapshotStore can reply with SnapshotNotFound if it is saving an EntitySnapshot #183

Merged
merged 3 commits into from
Oct 28, 2022
Merged

SnapshotStore can reply with SnapshotNotFound if it is saving an EntitySnapshot #183

merged 3 commits into from
Oct 28, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Oct 28, 2022

Closes #182

Taichi Yamakawa added 3 commits October 28, 2022 11:56
@xirc xirc added this to the v2.2.0 milestone Oct 28, 2022
@xirc xirc marked this pull request as ready for review October 28, 2022 03:03
@xirc xirc requested a review from negokaz October 28, 2022 03:03
negokaz
negokaz approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@negokaz negokaz enabled auto-merge October 28, 2022 03:10
@negokaz negokaz merged commit e7e0585 into master Oct 28, 2022
@negokaz negokaz deleted the snapshot-store-reply-with-snapshot-not-found branch October 28, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

SnapshotStore doesn't reply with SnapshotNotFound some times
2 participants
@xirc @negokaz