Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set disabled shards only by API #188

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Set disabled shards only by API #188

merged 3 commits into from
Nov 17, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Nov 16, 2022

  • Provide API ClusterReplicationSettings.withDisabledShards for setting disabled shards
  • Not to provide a config entry (lerna.akka.entityreplication.raft.disabled-shards) to prevent stopping RaftActors across all type names (for now)
  • Provide document about disabling Raft shards

@xirc xirc marked this pull request as ready for review November 16, 2022 05:55
@xirc xirc added this to the v2.2.0 milestone Nov 16, 2022
@xirc xirc requested a review from negokaz November 16, 2022 05:55
negokaz
negokaz approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@negokaz negokaz merged commit 7d7d4ee into master Nov 17, 2022
@negokaz negokaz deleted the set-disabled-shards-only-by-api branch November 17, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xirc @negokaz