Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostic logs to SnapshotStore #196

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Add diagnostic logs to SnapshotStore #196

merged 2 commits into from
Nov 30, 2022

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Nov 29, 2022

Add diagnostic logs to SnapshotStore:
SnapshotStore logs DEBUG messages when:

  • It starts.
  • It attempts to save EntitySnapshot.
  • It succeeded in save of EntitySnapshot.
  • It attempts to save EntitySnapshot as an Akka Persistence snapshot.
  • It stops when it is inactive.

@xirc xirc marked this pull request as ready for review November 29, 2022 08:43
@xirc xirc added this to the v2.2.0 milestone Nov 29, 2022
@xirc xirc requested a review from negokaz November 29, 2022 08:55
negokaz
negokaz approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@negokaz negokaz enabled auto-merge November 29, 2022 11:44
@negokaz negokaz merged commit ac4f10f into master Nov 30, 2022
@negokaz negokaz deleted the snapshot-store-diagnostic-logging branch November 30, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xirc @negokaz