Support deleting old events and snapshots #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirc
added
enhancement
negokaz
reviewed
May 10, 2023
core/src/test/scala/lerna/akka/entityreplication/raft/RaftActorPersistenceDeletionSpec.scala
Outdated
Show resolved
Hide resolved
...a/akka/entityreplication/raft/snapshot/sync/SnapshotSyncManagerPersistenceDeletionSpec.scala
Show resolved
Hide resolved
added 5 commits
May 12, 2023 11:50
For verifying no deletions have happened.
A rollback can specify more old timestamps as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #201
akka-entity-replicationsupports deleting old events and snapshots. This deletion feature is an opt-in feature (disabled is the default) since it only supports the Akka Persistence Cassandra. The deletion criteria is based on sequence number.There are four related persistent actors:
lerna.akka.entityreplication.raft.RaftActorlerna.akka.entityreplication.raft.snapshot.sync.SnapshotSyncManagerlerna.akka.entityreplication.raft.snapshot.SnapshotStorelerna.akka.entityreplication.raft.eventsourced.CommitLogStoreActorThey delete old events and snapshots automatically when they save a snapshot. If a deletion fails, they will log a warning message.
The newly introduced settings are:
lerna.akka.entityreplication.raft.delete-old-eventslerna.akka.entityreplication.raft.delete-old-snapshotslerna.akka.entityreplication.raft.delete-before-relative-sequence-nrlerna.akka.entityreplication.raft.snapshot-sync.delete-old-eventslerna.akka.entityreplication.raft.snapshot-sync.delete-old-snapshotslerna.akka.entityreplication.raft.snapshot-sync.delete-before-relative-sequence-nrlerna.akka.entityreplication.raft.entity-snapshot-store.delete-old-eventslerna.akka.entityreplication.raft.entity-snapshot-store.delete-old-snapshotslerna.akka.entityreplication.raft.entity-snapshot-store.delete-before-relative-sequence-nrlerna.akka.entityreplication.raft.eventsourced.persistence.delete-old-eventslerna.akka.entityreplication.raft.eventsourced.persistence.delete-old-snapshotslerna.akka.entityreplication.raft.eventsourced.persistence.delete-before-relative-sequence-nr