Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CassandraPersistenceQueries handles deleted partitions #209

Merged

Conversation

xirc
Copy link
Contributor

@xirc xirc commented May 17, 2023

Closes #207, #208

By using the highest deleted sequence number (deleted_to), CassandraPersistenceQueries handles deleted partitions (those partitions' all events have been deleted).

deleted_to is described as:

@xirc xirc added this to the v2.3.0 milestone May 17, 2023
@xirc xirc marked this pull request as ready for review May 17, 2023 08:40
@xirc xirc requested a review from negokaz May 17, 2023 08:40
negokaz
negokaz previously approved these changes May 19, 2023
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I left a comment.

Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@negokaz negokaz merged commit f179cb1 into master May 24, 2023
@negokaz negokaz deleted the cassandra-persistence-queries-handles-deleted-partitions branch May 24, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants