Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for deleting old data #212

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Add tests for deleting old data #212

merged 6 commits into from
Jun 12, 2023

Conversation

xirc
Copy link
Contributor

@xirc xirc commented Jun 9, 2023

Add unit tests, which improve test coverage, for the following persistent actors:

  • RaftActor
  • CommitLogStoreActor
  • SnapshotStore
  • SnapshotSyncManager

@xirc xirc added this to the v2.3.0 milestone Jun 9, 2023
@xirc xirc marked this pull request as ready for review June 9, 2023 08:22
@xirc xirc requested a review from negokaz June 9, 2023 08:22
negokaz
negokaz approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@negokaz negokaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 👍

@negokaz negokaz merged commit 63fe206 into master Jun 12, 2023
@negokaz negokaz deleted the add-tests-for-deleting-old-data branch June 12, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@negokaz negokaz negokaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xirc @negokaz