Make internal API private #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negokaz
force-pushed
the
adjust-public-api
branch
2 times, most recently
from
0a9bca6 to
25d4d36
Compare
negokaz
force-pushed
the
adjust-public-api
branch
from
6d6d0f7 to
a4b1ce9
Compare
Merged
tksugimoto
reviewed
Apr 5, 2021
src/main/scala/lerna/akka/entityreplication/ClusterReplication.scala
Outdated
Show resolved
Hide resolved
tksugimoto
reviewed
Apr 5, 2021
Only expose the setting values in the config file to users
negokaz
force-pushed
the
adjust-public-api
branch
from
2d9c518 to
279a7c3
Compare
tksugimoto
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #45
The following APIs should keep public (reference: akka-entity-replication/implementation_guide.md)
TODO