[Typed] Implement ClusterReplication #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
from
c8eba05 to
3a52fa0
Compare
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
3 times, most recently
from
c937238 to
bb18867
Compare
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
from
ce3671e to
70b0879
Compare
negokaz
commented
May 13, 2021
src/test/scala/lerna/akka/entityreplication/typed/ClusterReplicationSpec.scala
Outdated
Show resolved
Hide resolved
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
2 times, most recently
from
e45c76c to
63ffbe3
Compare
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
2 times, most recently
from
a9d36a7 to
b3dee04
Compare
For checking that ClusterReplication.init doesn't create duplicated region. toTyped method produces a new instance each time.
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
3 times, most recently
from
e52fd05 to
0662fe1
Compare
typed ActorSystem doesn't allow system.actorOf I faced the following error. > cannot create top-level actor [replicationRegion-GetEntityContext] from the outside on ActorSystem with custom user guardian
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
from
0662fe1 to
0a5990a
Compare
tksugimoto
suggested changes
May 18, 2021
src/main/scala/lerna/akka/entityreplication/model/NormalizedEntityId.scala
Outdated
Show resolved
Hide resolved
src/main/scala/lerna/akka/entityreplication/model/NormalizedEntityId.scala
Outdated
Show resolved
Hide resolved
src/main/scala/lerna/akka/entityreplication/typed/internal/ClusterReplicationImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/lerna/akka/entityreplication/typed/internal/ClusterReplicationImpl.scala
Show resolved
Hide resolved
src/main/scala/lerna/akka/entityreplication/typed/internal/ClusterReplicationImpl.scala
Outdated
Show resolved
Hide resolved
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
2 times, most recently
from
a593f23 to
7d7cb92
Compare
tksugimoto
force-pushed
the
typed/cluster-replication-impl
branch
from
7d7cb92 to
efc72b0
Compare
tksugimoto
approved these changes
May 24, 2021
tksugimoto
previously approved these changes
May 26, 2021
|
force push で 1 commit を 消したら CIが途中で止まってしまったようです。
re-run できそうなところやってみましたが変わらず。 最新commitを |
negokaz
force-pushed
the
typed/cluster-replication-impl
branch
from
efc72b0 to
a65a8e6
Compare
|
@tksugimoto CI がパスしました。Approve お願いします。 |
tksugimoto
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #44
TODO
NOTE