Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands: pass execOpts to all utilities executions #733

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

evocateur
Copy link
Member

@evocateur evocateur commented Apr 6, 2017

Description

Pass opts.cwd to all utility executions (in addition to existing opts, if present).

Motivation and Context

This aims to remove any implicit reliance on process.cwd(), improving consistency and laying more groundwork for concurrent unit tests.

This builds on the work done in #714.

How Has This Been Tested?

Updated existing unit test suite.

Types of changes

  • Internal

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur evocateur merged commit 0cd40ec into lerna:master Apr 6, 2017
@evocateur evocateur deleted the avoid-implicit-cwd branch April 6, 2017 21:05
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant