Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde_bytes crate for serializing Schema::Bytes #36

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

martin-g
Copy link
Contributor

Reported at Apache Avro user@ mailing list: https://lists.apache.org/thread/cmkc6b7g5pqh63odtrj5vg502w7o4n4h

Reported at Apache Avro user@ mailing list: https://lists.apache.org/thread/cmkc6b7g5pqh63odtrj5vg502w7o4n4h

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@lerouxrgd lerouxrgd merged commit 114b4e5 into lerouxrgd:master Aug 30, 2022
@lerouxrgd
Copy link
Owner

Thanks for the PR !

@martin-g martin-g deleted the serde-bytes branch August 30, 2022 08:32
@martin-g
Copy link
Contributor Author

Once serde-rs/bytes#26 is implemented we can do the same for Schema::Fixed too

@martin-g
Copy link
Contributor Author

Or maybe use https://github.com/jonasbb/serde_with instead ?!

@rajivr
Copy link

rajivr commented Aug 30, 2022

Or maybe use https://github.com/jonasbb/serde_with instead ?!

I took a look at serde_with before replying to your e-mail. Its just my personal opinion, but I felt the code base of serde-rs/bytes is simpler. It is also maintained within the Serde project, by the same maintainers. Hence, I went with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants