Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async-fix #6

Merged
merged 6 commits into from
May 8, 2022
Merged

Async-fix #6

merged 6 commits into from
May 8, 2022

Conversation

leshchenko1979
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022

Codecov Report

Merging #6 (ef34731) into master (534617e) will increase coverage by 9.33%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master        #6      +/-   ##
===========================================
+ Coverage   90.66%   100.00%   +9.33%     
===========================================
  Files           5         3       -2     
  Lines         257        85     -172     
===========================================
- Hits          233        85     -148     
+ Misses         24         0      -24     
Impacted Files Coverage Δ
tests/test_retry.py
setup.py
reretry/api.py 100.00% <0.00%> (+5.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534617e...ef34731. Read the comment docs.

@sourcery-ai
Copy link

sourcery-ai bot commented May 8, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.56%.

Quality metrics Before After Change
Complexity 1.23 ⭐ 1.38 ⭐ 0.15 👎
Method Length 28.31 ⭐ 30.60 ⭐ 2.29 👎
Working memory 4.18 ⭐ 4.68 ⭐ 0.50 👎
Quality 89.39% 87.83% -1.56% 👎
Other metrics Before After Change
Lines 282 231 -51
Changed files Quality Before Quality After Quality Change
tests/test_retry.py 89.39% ⭐ 87.83% ⭐ -1.56% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@leshchenko1979 leshchenko1979 merged commit a34ef8b into master May 8, 2022
@leshchenko1979 leshchenko1979 deleted the async-fix branch May 8, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants