Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue:4267) support starting-style at-rule #4289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

puckowski
Copy link
Contributor

What:

This pull request resolves issue #4247 by fixing @starting-style at-rule nesting.

Why:

Users of Less.js may wish to use newer features of CSS supported by newer versions of most browsers. Estimated support for @starting-style is 84.76%+ (https://caniuse.com/mdn-css_at-rules_starting-style).

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

Bundle size:

Less.js 4.2.1 minified is 151,936 bytes.
With PR merged Less.js bundle minified becomes 155,088 bytes.
Delta: 3,152 bytes

Lines of code delta: 275 added (including tests)

The following Less:

[popover]:popover-open {
    opacity: 1;
    transform: scaleX(1);

    @starting-style {
        opacity: 0;
        transform: scaleX(0);
    }
}

becomes:

[popover]:popover-open {
  opacity: 1;
  transform: scaleX(1);
  @starting-style {
    opacity: 0;
    transform: scaleX(0);
  }
}

* Add support for ```@starting-style``` at-rule now that browser support
  is broader.
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 25, 2024
@puckowski
Copy link
Contributor Author

I submitted a few PRs. I expect rebase(s) will be needed in order to merge all of them, so let me know when a rebase is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant