Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: store presets in database via metadata store #1013

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Conversation

sarahwooders
Copy link
Collaborator

@sarahwooders sarahwooders commented Feb 15, 2024

Please describe the purpose of this pull request.
In order to allow users to programmatically define presets (e.g. via the REST API), we need to store presets in the database.

Currently, we still require functions to be defined locally, but these should also be moved into the DB.

TODOS

  • Add memgpt list presets option
  • Support adding presets via server
  • Support adding presets via client
  • Write preset creation test

How to test
poetry run pytest -s tests/test_client.py

Have you tested this PR?
Yes

Related issues or PRs
Required to support defining assistants in #892

@sarahwooders sarahwooders marked this pull request as draft February 15, 2024 20:58
@sarahwooders sarahwooders requested a review from cpacker February 15, 2024 20:58
@sarahwooders sarahwooders marked this pull request as ready for review February 15, 2024 22:39
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cpacker cpacker merged commit c7fbc03 into main Feb 16, 2024
4 checks passed
@cpacker cpacker deleted the preset-refactor branch February 16, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants