-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create RESTClient
and Admin
client for interacting with server from python
#1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RESTClient
and Admin
client for interacting with server from pythonRESTClient
and Admin
client for interacting with server from python
cpacker
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM left some comments but they don't necessarily need to addressed in this PR
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
This refactors the client to have both a
LocalClient
andRESTClient
, where the latter connects to a running server. The quickstart configuration is also removed, since the client it not responsible for configuring the LLM/embedding endpoints (this is controlled by the server).User Identification
A single
Client
instance corresponds to a single user.RESTClient
.LocalClient
(which does not require authentication, since it does not connect through the REST server), there is an associateduser_id
which is read from~/.memgpt/config
.User Creation
memgpt server
, users are created via a specialAdmin()
client which can run admin commandsmemgpt configure
is run