Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip empty string passages returned by llama index parsing #1208

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix: skip empty string passages returned by llama index parsing #1208

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36c9adb
fix file upload route
sarahwooders Mar 20, 2024
026c279
actually merge
sarahwooders Mar 21, 2024
1bf9b34
catch case where llama index returns empty string
sarahwooders Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions memgpt/data_sources/connectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ def load_data(

# generate passages
for passage_text, passage_metadata in connector.generate_passages([document], chunk_size=embedding_config.embedding_chunk_size):

# for some reason, llama index parsers sometimes return empty strings
if len(passage_text) == 0:
typer.secho(
f"Warning: Llama index parser returned empty string, skipping insert of passage with metadata '{passage_metadata}' into VectorDB. You can usually ignore this warning.",
fg=typer.colors.YELLOW,
)
continue

# get embedding
try:
embedding = embed_model.get_text_embedding(passage_text)
except Exception as e:
Expand Down
Loading