-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clean up and simplify docker entrypoint (#1235) #1259
Conversation
@norton120 thanks for all these contributions -- they really cleanup the code so really appreciate it! A couple questions about this PR:
Also regarding the test failures, I believe the |
@sarahwooders happy to help - I'll run through this today and get things working as expected for running in docker, and isolate all the bits for developing in docker so they don't hold it up. I can button up the docker dev env in a separate PR after |
@sarahwooders Got those fixes ready but it looks like I can't push to this branch, should I push them to #1259? |
@norton120 actually yeah lets maybe move back to your fork, since I don't think there's an easy way to give you permissions to push (sorry didn't realize). Can you give us access to your fork? Thanks! |
@norton120 could you open a new PR again, and make sure to allow maintainers to edit the pull request? |
@sarahwooders Updated PR is here with this as the base branch, you should have access but lemme know if not. If it is easier to point to main then let's do that - whatever works! Let me know if you run into any issues with the proxy, I've scrubbed all my local images a couple times to make sure it works without any leftover artifacts (ie |
Co-authored-by: Ethan Knox <[email protected]>
Continuation of #1235 by @norton120