Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add character limits for persona/human to /config response #1546

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

goetzrobin
Copy link
Contributor

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

Adding CORE_MEMORY_HUMAN_CHAR_LIMIT and CORE_MEMORY_PERSONA_CHAR_LIMIT to the /config response
so they can be used to dynamically adjust the frontend text area limits

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

@sarahwooders sarahwooders self-requested a review July 25, 2024 16:45
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sarahwooders sarahwooders merged commit 9be2279 into letta-ai:main Jul 25, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants