-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add common + custom settings files for completion endpoints #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacker
changed the title
Add common + custom settings files for completion endpoints
[Draft] Add common + custom settings files for completion endpoints
Dec 16, 2023
cpacker
changed the title
[Draft] Add common + custom settings files for completion endpoints
feat: Add common + custom settings files for completion endpoints
Dec 17, 2023
…erride in memgpt dir, hooked up lmstudio to new workflow
cpacker
commented
Dec 18, 2023
cpacker
commented
Dec 18, 2023
cpacker
commented
Dec 18, 2023
cpacker
commented
Dec 18, 2023
sarahwooders
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
sarahwooders
pushed a commit
that referenced
this pull request
Dec 26, 2023
norton120
pushed a commit
to norton120/MemGPT
that referenced
this pull request
Feb 15, 2024
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
mattzh72
added a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #623
TODOs
~/.memgpt/settings/completions.py
)Separate PR?
- [ ] Make openai/azure pull from common/chat/completions
settings file- [ ] Allow override from user directory (eg override temperature easily)Please describe the purpose of this pull request
~/.memgpt
home directoryHow to test
Run inference via the backend and watch the backend endpoint to make sure settings are getting passed through properly (certain endpoints may require renaming of variables).
Have you tested this PR?