fix: Throw "env vars not set" early and enhance /attach for KeyboardInterrupt (#669) #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacker
changed the title
Closed
2 tasks
cpacker
approved these changes
Dec 22, 2023
cpacker
added a commit
that referenced
this pull request
Dec 22, 2023
* for openai, check for key and if missing allow user to pass it, for azure, throw error if the key isn't present * correct prior checking of azure to be more strict, added similar checks at the embedding endpoint config stage * forgot to override value in config before saving * clean up the valuerrors from missing keys so that no stacktrace gets printed, make success text green to match others
sarahwooders
pushed a commit
that referenced
this pull request
Dec 26, 2023
sarahwooders
pushed a commit
that referenced
this pull request
Dec 26, 2023
* for openai, check for key and if missing allow user to pass it, for azure, throw error if the key isn't present * correct prior checking of azure to be more strict, added similar checks at the embedding endpoint config stage * forgot to override value in config before saving * clean up the valuerrors from missing keys so that no stacktrace gets printed, make success text green to match others
norton120
pushed a commit
to norton120/MemGPT
that referenced
this pull request
Feb 15, 2024
norton120
pushed a commit
to norton120/MemGPT
that referenced
this pull request
Feb 15, 2024
* for openai, check for key and if missing allow user to pass it, for azure, throw error if the key isn't present * correct prior checking of azure to be more strict, added similar checks at the embedding endpoint config stage * forgot to override value in config before saving * clean up the valuerrors from missing keys so that no stacktrace gets printed, make success text green to match others
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
* for openai, check for key and if missing allow user to pass it, for azure, throw error if the key isn't present * correct prior checking of azure to be more strict, added similar checks at the embedding endpoint config stage * forgot to override value in config before saving * clean up the valuerrors from missing keys so that no stacktrace gets printed, make success text green to match others
mattzh72
added a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: Charles Packer <[email protected]> Co-authored-by: dboyliao <[email protected]> Co-authored-by: Shubham Naik <[email protected]> Co-authored-by: Shubham Naik <[email protected]> Co-authored-by: Caren Thomas <[email protected]> Co-authored-by: Sarah Wooders <[email protected]> Co-authored-by: Jyotirmaya Mahanta <[email protected]> Co-authored-by: Stephan Fitzpatrick <[email protected]> Co-authored-by: Stephan Fitzpatrick <[email protected]> Co-authored-by: mlong93 <[email protected]> Co-authored-by: Mindy Long <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
This pull request addresses Issue #669, which is related to CLI conveniences. It fixes the issue of environment variables not being set early and enhances the /attach command to respect KeyboardInterrupt.
How to test
memgpt configurewithout setting OpenAI and Azure environment variables.Have you tested this PR?
Yes, I have tested the latest commit on this PR. The /attach command now behaves as expected, and the "env vars not set" error is thrown early during
memgpt configure.Related issues or PRs
Issue #669
Is your PR over 500 lines of code?
No, the changes are concise and do not exceed 500 lines.