Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved configs for hosted to https, patched bug in embedding creation #685

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Dec 23, 2023

Please describe the purpose of this pull request.

  • Moved hosted endpoint addresses to https (tested it's working)
  • While testing I noticed that there was a bug w/ embedding creation, and patched it

# eg: embedding={'object': 'list', 'data': [{'object': 'embedding', 'embedding': [-0.0071973633, -0.07893023,
if isinstance(embedding, dict):
try:
embedding = embedding["data"][0]["embedding"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahwooders I'm not sure if this is a llama-index bug, or if it's to do with how we're returning the payload from the hosted embedding server

@cpacker cpacker requested a review from sarahwooders December 23, 2023 01:48
@cpacker cpacker merged commit 7a019f0 into main Dec 23, 2023
3 checks passed
@cpacker cpacker deleted the update-quickstart-config branch December 24, 2023 08:35
sarahwooders pushed a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant