fix: fix string & ws rules in json_func_calls...gbnf #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
cpacker
changed the title
cpacker
changed the title
|
@cpacker I have tested this enough to be confident that it is at least as good as the original code 😏. (I have to wrap my head around doing this kind of development: writing unit tests is not straightforward.) I think this PR is ready for your approval. PTAL |
cpacker
approved these changes
Jan 2, 2024
|
Thank you for this PR! |
norton120
pushed a commit
to norton120/MemGPT
that referenced
this pull request
Feb 15, 2024
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
I believe this fixes a bug with json_func_calls...gbnf. See issue #748
How to test
Manual testing only (for now). I am currently testing with NexusRaven-V2-13B and the temperature reduced to 0.01. Engage in discussion about C/C++ or any language with braces.
Have you tested this PR?
I am still testing. This is WIP.
Related issues or PRs
#748
Is your PR over 500 lines of code?
No
Additional context
See issue #748