Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: patch mem lim exceeded #977

Merged
merged 8 commits into from
Feb 9, 2024
Merged

fix: patch mem lim exceeded #977

merged 8 commits into from
Feb 9, 2024

Conversation

cpacker
Copy link
Collaborator

@cpacker cpacker commented Feb 8, 2024 •
edited
Loading

Please describe the purpose of this pull request.

  • Fix ValueError: function_call == None not supported (auto only) bug (ValueError: function_call == None not supported (auto only) #967)
    • Solution: just allow both None or auto instead of just auto
  • Fix issue with persistence manager's .message attribute not matching the agent's (at least in length) (Memory context limit exceeded #957)
    • Solution: remove persistence manager's .message attribute and associated accesses
    • It's not needed for anything anymore
    • TODO: eventually strip persistence manager class and access recall/archival directly
      • TODO since there are quite a few accesses to persistence manager that will need to be modified

How to test

New test test_summarize, run on a local machine

Have you tested this PR?

Yes, using LM Studio + LLM w/ 4k context

This was linked to issues Feb 8, 2024
Memory context limit exceeded #957
Closed
ValueError: function_call == None not supported (auto only) #967
Closed
@cpacker cpacker merged commit bc75285 into main Feb 9, 2024
4 checks passed
@cpacker cpacker deleted the patch-mem-lim-exceeded branch February 9, 2024 04:02
@cpacker cpacker mentioned this pull request Feb 9, 2024
Closed
6 tasks
norton120 pushed a commit to norton120/MemGPT that referenced this pull request Feb 15, 2024
@cpacker @norton120
fix: patch mem lim exceeded (letta-ai#977)
bbe07d0
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
@cpacker
fix: patch mem lim exceeded (#977)
6e7fc50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError: function_call == None not supported (auto only) Memory context limit exceeded
1 participant
@cpacker